Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GH-2009: Updated the dependencies to support Node.js 10.x.x. #3768

Closed
wants to merge 3 commits into from

Conversation

kittaakos
Copy link
Contributor

Closes #2009.

Akos Kitta added 3 commits December 6, 2018 16:19
Closes #2009.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
!!SQUASH ME

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@AlexTugarev
Copy link
Contributor

AlexTugarev commented Dec 11, 2018

fyi, I had to bump this versions too:

"vscode-nsfw": "^1.1.2"
"electron-rebuild": "^1.8.2"

was trying to answer another question, just wanted to share ;-)

@jankeromnes
Copy link
Member

jankeromnes commented Mar 13, 2019

Thanks for starting a fix! I've continued this work in #4556, so this pull request can now be closed.

@kittaakos
Copy link
Contributor Author

Closing in favor of #4556.

@kittaakos kittaakos closed this Mar 13, 2019
@kittaakos kittaakos deleted the GH-2009 branch June 12, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants