[WIP] Fix #4088: Add 'Upload Files...' menu entries #4166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
upload-files
branch
from
cdaed27 to
12eeb92
Compare
|
Then again, we might want to support uploading files on Firefox and other browsers too. My go-to library for this has always been https://github.com/felixge/node-formidable (super light-weight, works extremely well). Maybe I'll look into implementing that into Theia. |
|
However, as mentioned by @akosyakov in #4088 (comment), importing |
|
@jankeromnes if library improves ux a lot when use it, we will help with jumping through all necessary hoops. For now we don’t wait for dependency CQs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4088: Add an
Upload Files...menu entries.ToDo:
<input type="file" multiple>to Theia's DOM somewhere, and trigger it from the new menu entriesinput.files(which is a FileList) and send it toFileTreeModel.upload()(which takes a DataTransferItemList:)https://github.com/theia-ide/theia/blob/5156023a4b0c590b40485f82d5c798c6ef6f8dec/packages/filesystem/src/browser/file-tree/file-tree-model.ts#L191-L196