Add ability to pass argument for 'mini-browser.openUrl' command #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RomanNikitenko Is it to implement #4051? |
|
@akosyakov I need it for eclipse-che/che#11458 to implement Preview URL functionality, so to replace this part code of extension |
akosyakov
approved these changes
Feb 5, 2019
| @@ -170,7 +170,7 @@ export class MiniBrowserOpenHandler extends NavigatableWidgetOpenHandler<MiniBro | |||
| isVisible: widget => !!this.getSourceUri(widget) | |||
| }); | |||
| commands.registerCommand(MiniBrowserCommands.OPEN_URL, { | |||
| execute: () => this.openUrl() | |||
| execute: (arg: string) => this.openUrl(arg) | |||
There was a problem hiding this comment.
fixed, thank you!
| @@ -243,8 +243,8 @@ export class MiniBrowserOpenHandler extends NavigatableWidgetOpenHandler<MiniBro | |||
| return uri; | |||
| } | |||
|
|
|||
| protected async openUrl(): Promise<void> { | |||
| const url = await this.quickInputService.open({ | |||
| protected async openUrl(arg: string | undefined): Promise<void> { | |||
There was a problem hiding this comment.
arg?: string should be optional, for backward compatibility
There was a problem hiding this comment.
fixed, thank you!
@akosyakov I don't think so, in VS Code for "previewHtml" used TextDocumentContentProviders |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
openPreviewUrl
branch
from
bb0d63a
to
5d4dbf5
Compare
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to pass argument for 'mini-browser.openUrl' command will allow to open URL in the Preview Tab without asking user to enter this one.
It would be very useful for plugin side, for example.
Signed-off-by: Roman Nikitenko rnikiten@redhat.com