Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alt+shift+w closes all main area tabs #4559

Merged
merged 1 commit into from
Mar 14, 2019
Merged

alt+shift+w closes all main area tabs #4559

merged 1 commit into from
Mar 14, 2019

Conversation

spoenemann
Copy link
Contributor

Fixes #1999.

When invoked from the context menu, the command still closes the selected tab bar. When invoked via alt + shift + W, it closes all main area tabs.

Note that alt + W is unchanged: it closes the current widget, regardless in which shell area it resides.

@spoenemann
#1999: alt+shift+w closes all main area tabs
f8e9ec6 
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
@akosyakov akosyakov requested a review from kittaakos March 14, 2019 13:03
kittaakos
kittaakos approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, it works nicely. Thank you! 👍

@spoenemann spoenemann merged commit 67bc2d4 into master Mar 14, 2019
@spoenemann spoenemann deleted the msp_issue1999 branch March 14, 2019 13:50
@spoenemann spoenemann mentioned this pull request Feb 7, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[keybinding] Alt+Shift+W closes all tabs not just the editors
2 participants
@spoenemann @kittaakos