Follow up on plugins life-cycle / per connection scoped. #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed as now there can have several clients connected Change-Id: I604b9c44c4278b64c0572716beb053891ad7ae4c Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…ost. Change-Id: I511fc3690f8a553dbec15839eefc811f97d8d37f Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…nstances of the class. - Add helper method stopContext() (like initContext but for stopping) - Also introduce cleanup of the require cache to be sure to always have a proper initialization. Change-Id: Id536d9d524d5d39a43033eba20e9d2bb6209d18a Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
@akosyakov let me know if I need to add |
|
@benoitf if you want you can do it now, it looks like Ericsson team goes over issues before a release and groom CHANGELOG. I'm trying to make sure that breaking changes don't get missed. |
akosyakov
approved these changes
Mar 14, 2019
tolusha
approved these changes
Mar 14, 2019
azatsarynnyy
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of the #4521 PR that introduced per connection scoped on plug-ins
Runners need now to be notified when client is disconnected and the usage of static needs to be removed to ensure we get correct instances every time.