Fixes #4741 allow creation of sub-files and/or sub-folders if name has "/" #4764

uniibu · 2019-03-30T07:11:36Z

Fixes #4741. Creation of sub-files and/or sub-folders are already available,however, validation check does not allow / on the input box, making it impossible to create nested sub-folders and/or sub-files.

This PR allows recursive creation of folders or files via / .

allow recursive creation for New File and New Folder only.
do not allow creation of files and folders that starts with /
do not allow creation of files and folders that starts and ends with a whitepsace.
do not allow recursive create on Rename.

Example:

Creating a file using test/scripts/index.js will create test and test/scripts folder if it still does not exists and lastly it creates the file test/scripts/index.js

Signed-off-by: Uni Sayo unibtc@gmail.com

packages/core/src/browser/dialogs.ts

akosyakov · 2019-03-31T03:34:02Z

packages/workspace/src/browser/workspace-commands.ts

+        const childUri = new URI(parent.uri).resolve(name).toString();
+        this.fileSystem.exists(childUri).then(exists => {
+            if (exists && dialog) {
+                dialog.error(`A file or folder <strong>${fileName}</strong> already exists at this location.`);


We should change a type of validation function to MaybPromise<DialogError> to allow async validation. Inside the dialog we will need to make sure that concurrent validation does not occur, i.e. queue them or cancel.

akosyakov · 2019-03-31T03:36:45Z

I wonder can we override CtrlCmd + N browser short cut to create a new file, so annoying to click each time.

akosyakov · 2019-03-31T03:42:23Z

It does not work if i create the same path twice from the root, it seems to pick the wrong parent then which is very confusing. Not sure whether it is a new bug or something which was not apparent before. In order to reprdoce with Theia repo:

right click on theia folder -> New File -> configs/Untitled.txt and create a file
do the same again without doing anything else

I would expect an error, but there are non and the second file is created at the bogus location: theia/configs/configs/Untitled.txt

uniibu · 2019-04-02T04:04:15Z

It does not work if i create the same path twice from the root, it seems to pick the wrong parent then which is very confusing. Not sure whether it is a new bug or something which was not apparent before. In order to reprdoce with Theia repo:

right click on theia folder -> New File -> configs/Untitled.txt and create a file

do the same again without doing anything else

I would expect an error, but there are non and the second file is created at the bogus location: theia/configs/configs/Untitled.txt

This is because of inconsistent selection bug when creating a new file. Sometimes the new file gets selected on creation (which is what it is supposed to do) and sometimes it doesn't.
This is due to this line:
https://github.com/theia-ide/theia/blob/636533952fd4b42cfc834e346ec3402f0c5db343/packages/filesystem/src/browser/file-resource.ts#L119
which needs to be if (!await this.fileSystem.exists(this.uriString)) {

I've patched this on the latest commit.

packages/workspace/src/browser/workspace-commands.ts

packages/filesystem/src/browser/file-dialog/file-dialog.ts

akosyakov · 2019-04-02T04:19:49Z

packages/filesystem/src/browser/file-resource.ts

@@ -116,7 +116,7 @@ export class FileResource implements Resource {
    }

    protected async getFileStat(): Promise<FileStat | undefined> {
-        if (!this.fileSystem.exists(this.uriString)) {
+        if (!await this.fileSystem.exists(this.uriString)) {


how it used to work! ❤️ for fixing it!

packages/core/src/browser/dialogs.ts

akosyakov

It works nicely now, but there are some code clean up necessary to avoid breaking code org and race conditions.

packages/core/src/browser/dialogs.ts

akosyakov

works nicely, thank you

benoitf

thanks @uniibu I didn't expect someone will implement a fix for this issue very soon

packages/workspace/src/browser/workspace-commands.ts

This allow creation of files and folders recursive path. improve validation check, add cancellationtoken separate validation for absolutpath and leading/trailing spaces Signed-off-by: Uni Sayo <unibtc@gmail.com>

uniibu · 2019-04-02T10:22:04Z

i've separated the validation checks for absolute paths and leading and trailing spaces as per suggested. Squashed commits.

benoitf

thanks 👍 @uniibu

akosyakov reviewed Mar 31, 2019

View reviewed changes

packages/core/src/browser/dialogs.ts Outdated Show resolved Hide resolved

akosyakov reviewed Mar 31, 2019

View reviewed changes

uniibu force-pushed the recursive-create branch from 1450be2 to 3ba4c30 Compare April 2, 2019 04:11

akosyakov reviewed Apr 2, 2019

View reviewed changes

packages/workspace/src/browser/workspace-commands.ts Outdated Show resolved Hide resolved

akosyakov reviewed Apr 2, 2019

View reviewed changes

packages/filesystem/src/browser/file-dialog/file-dialog.ts Show resolved Hide resolved

akosyakov reviewed Apr 2, 2019

View reviewed changes

packages/core/src/browser/dialogs.ts Show resolved Hide resolved

akosyakov reviewed Apr 2, 2019

View reviewed changes

packages/core/src/browser/dialogs.ts Outdated Show resolved Hide resolved

akosyakov approved these changes Apr 2, 2019

View reviewed changes

benoitf reviewed Apr 2, 2019

View reviewed changes

packages/workspace/src/browser/workspace-commands.ts Show resolved Hide resolved

packages/workspace/src/browser/workspace-commands.ts Outdated Show resolved Hide resolved

allow promises on validate. fix inconsistent selection, add CHANGELOG

e49adaf

This allow creation of files and folders recursive path. improve validation check, add cancellationtoken separate validation for absolutpath and leading/trailing spaces Signed-off-by: Uni Sayo <unibtc@gmail.com>

uniibu force-pushed the recursive-create branch from ff5aaef to e49adaf Compare April 2, 2019 10:20

benoitf approved these changes Apr 2, 2019

View reviewed changes

benoitf merged commit b0a7da6 into eclipse-theia:master Apr 2, 2019

uniibu deleted the recursive-create branch April 2, 2019 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #4741 allow creation of sub-files and/or sub-folders if name has "/" #4764

Fixes #4741 allow creation of sub-files and/or sub-folders if name has "/" #4764

uniibu commented Mar 30, 2019

akosyakov Mar 31, 2019

akosyakov commented Mar 31, 2019

akosyakov commented Mar 31, 2019

uniibu commented Apr 2, 2019

akosyakov Apr 2, 2019

akosyakov left a comment

akosyakov left a comment

benoitf left a comment

uniibu commented Apr 2, 2019

benoitf left a comment

Fixes #4741 allow creation of sub-files and/or sub-folders if name has "/" #4764

Fixes #4741 allow creation of sub-files and/or sub-folders if name has "/" #4764

Conversation

uniibu commented Mar 30, 2019

akosyakov Mar 31, 2019

Choose a reason for hiding this comment

akosyakov commented Mar 31, 2019

akosyakov commented Mar 31, 2019

uniibu commented Apr 2, 2019

akosyakov Apr 2, 2019

Choose a reason for hiding this comment

akosyakov left a comment

Choose a reason for hiding this comment

akosyakov left a comment

Choose a reason for hiding this comment

benoitf left a comment

Choose a reason for hiding this comment

uniibu commented Apr 2, 2019

benoitf left a comment

Choose a reason for hiding this comment