[electron] Bind plugin components on the backend #4842
Conversation
|
@benoitf @evidolob hi, I was trying to enable plugins on Electron and I was wondering how to properly test that most of it is working as it should? I tried the Ruby extension from VS Code so far, I could see snippets being contributed, but is there something for me to follow to more extensively test this change? Also wanted feedback on the bindings, because I just naively hooked what seemed to be missing, but I am certainly missing some runtime assumptions (some things might be meant to run in a NodeJS env and not Electron, etc...). I was expecting to be able to start with naive changes, and work my way there by running some tests and updating the bindings/implementations accordingly. |
paul-marechal
added
electron
|
@marechal-p try to run something well tested like go-vscode extension and test with this project https://github.com/demo-apps/go-gin-app It should suggest you to install tooling, provide language support and so on. Just take your time to learn this extension (maybe go as well :)) and check that it works nicely in Electron. |
|
@akosyakov tried the go extension as you said, and everything looked fine :)
Tried a few other extensions, all seem to work as expected. |
|
@marechal-p ok, let me verify as well |
The electron inversify container is missing a couple of bindings required by the whole plugin system to work correctly. This commit binds what is missing for plugins to function on electron. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
mp/electron-plugins
branch
from
c9e251d to
f37b6ab
Compare
|
@marechal-p I've rebased and added the missing option, please pull before force pushing next time. After Gitpod is green i will test Electron. |
|
Although it does not mean that it will work in the bundled app. It would be nice to test it as well after merging. |
I was trying to bundle an Electron application on Linux using I mean I will eventually make it work, but did anyone already made such a bundle on Linux? |
The electron inversify container is missing a couple of bindings
required by the whole plugin system to work correctly.
This commit binds what is missing for plugins to function on electron.
Signed-off-by: Paul Maréchal paul.marechal@ericsson.com
Fixes #4802
Fixes #3651
Fixes #2210