Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate extension manager #4876

Merged
merged 1 commit into from
Apr 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Breaking changes:
}
}
```
- [extension-manager] deprecated [#4876](https://github.com/theia-ide/theia/pull/4876)

## v0.5.0

Expand Down
1 change: 0 additions & 1 deletion examples/browser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@theia/editor": "^0.5.0",
"@theia/editor-preview": "^0.5.0",
"@theia/editorconfig": "^0.5.0",
"@theia/extension-manager": "^0.5.0",
"@theia/file-search": "^0.5.0",
"@theia/filesystem": "^0.5.0",
"@theia/getting-started": "^0.5.0",
Expand Down
10 changes: 0 additions & 10 deletions examples/browser/test/left-panel/left-panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,6 @@ export class LeftPanel {
this.driver.pause(300);
}

isExtensionsContainerVisible(): boolean {
return this.driver.isExisting('#extensions') && (this.driver.element('#extensions').getAttribute('class').split(' ').indexOf('theia-extensions') !== -1);
}

waitForExtensionsViewVisible(): void {
this.driver.waitForVisible('#extensions');
// Wait for animations to finish
this.driver.pause(300);
}

isGitHistoryContainerVisible(): boolean {
return (this.driver.isExisting('#git-history') && this.driver.element('#git-history').getAttribute('class').split(' ').indexOf('p-mod-hidden') === -1
&& this.isPanelVisible());
Expand Down
5 changes: 0 additions & 5 deletions examples/browser/test/top-panel/top-panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ export class TopPanel {
this.clickSubMenu('Call Hierarchy');
}

toggleExtensionsView() {
this.clickMenuTab('View');
this.clickSubMenu('Extensions');
}

toggleFilesView() {
this.clickMenuTab('View');
this.clickSubMenu('Explorer');
Expand Down
15 changes: 0 additions & 15 deletions examples/browser/test/top-panel/top-panel.ui-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,21 +114,6 @@ describe('theia top panel (menubar)', () => {
});
});

describe('extensions view UI', () => {
it('should start with extensions view not visible', () => {
expect(leftPanel.isExtensionsContainerVisible()).to.be.false;
});
it('extensions view should toggle-on then toggle-off', () => {
if (!leftPanel.isExtensionsContainerVisible()) {
topPanel.toggleExtensionsView();
leftPanel.waitForExtensionsViewVisible();
}
expect(leftPanel.isExtensionsContainerVisible()).to.be.true;
topPanel.toggleExtensionsView();
expect(leftPanel.isExtensionsContainerVisible()).to.be.false;
});
});

describe('files view UI', () => {
it('should start with files view not visible', () => {
expect(leftPanel.isFileTreeVisible()).to.be.false;
Expand Down
1 change: 0 additions & 1 deletion examples/electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"@theia/editor": "^0.5.0",
"@theia/editor-preview": "^0.5.0",
"@theia/editorconfig": "^0.5.0",
"@theia/extension-manager": "^0.5.0",
"@theia/file-search": "^0.5.0",
"@theia/filesystem": "^0.5.0",
"@theia/getting-started": "^0.5.0",
Expand Down
32 changes: 32 additions & 0 deletions packages/core/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
# Theia - Core extension

See [here](https://www.theia-ide.org/doc/index.html) for a detailed documentation.

## Theia Extension

A Theia extension is a node package declaring `theiaExtensions` property in `package.json`:

```json
{
"theiaExtensions": [{
"frontend": "lib/myExtension/browser/myextension-frontend-module",
"backend": "lib/myExtension/node/myextension-backend-module",
}, {
"frontend": "lib/myExtension2/browser/myextension2-browser-module",
"frontendElectron": "lib/myExtension2/electron-browser/myextension2-electron-browser-module",
"backend": "lib/myExtension2/node/myextension2-node-module",
"backendElectron": "lib/myExtension2/electron-main/myextension2-electron-main-module"
}]
}
```

Each extension can consist of the following modules:
- `frontend` is used in the browser env and as well in the electron if `frontendElectron` is not provided
- `frontendElectron` is used in the electron env
- `backend` is used in the node env and as well in the electron env if `backendElectron` is not provided
- `backendElectron` is used in the electron env

An extension module should have a default export of `ContainerModule | Promise<ContainerModule>` type.

## Theia Application

A Theia application is a node package listing [Theia extensions](#theia-extension) as dependencies and managed with [Theia CLI](../../dev-packages/cli/README.md).

## Logging configuration

It's possible to change the log level for the entire Theia application by
Expand Down
34 changes: 2 additions & 32 deletions packages/extension-manager/README.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,7 @@
# Theia - Extension Manager

See [here](https://www.theia-ide.org/doc/index.html) for a detailed documentation.

## Theia Extension

A Theia extension is a node package declaring `theiaExtensions` property in `package.json`:

```json
{
"theiaExtensions": [{
"frontend": "lib/myExtension/browser/myextension-frontend-module",
"backend": "lib/myExtension/node/myextension-backend-module",
}, {
"frontend": "lib/myExtension2/browser/myextension2-browser-module",
"frontendElectron": "lib/myExtension2/electron-browser/myextension2-electron-browser-module",
"backend": "lib/myExtension2/node/myextension2-node-module",
"backendElectron": "lib/myExtension2/electron-main/myextension2-electron-main-module"
}]
}
```

Each extension can consist of the following modules:
- `frontend` is used in the browser env and as well in the electron if `frontendElectron` is not provided
- `frontendElectron` is used in the electron env
- `backend` is used in the node env and as well in the electron env if `backendElectron` is not provided
- `backendElectron` is used in the electron env

An extension module should have a default export of `ContainerModule | Promise<ContainerModule>` type.

## Theia Application

A Theia application is a node package listing [Theia extensions](#theia-extension) as dependencies and managed with [Theia CLI](../../dev-packages/cli/README.md).
This extension is depreacted. It will be merged into the plugin management eventually in order to reuse UI.

## License
- [Eclipse Public License 2.0](http://www.eclipse.org/legal/epl-2.0/)
- [一 (Secondary) GNU General Public License, version 2 with the GNU Classpath Exception](https://projects.eclipse.org/license/secondary-gpl-2.0-cp)
- [一 (Secondary) GNU General Public License, version 2 with the GNU Classpath Exception](https://projects.eclipse.org/license/secondary-gpl-2.0-cp)
3 changes: 0 additions & 3 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
"@theia/core/lib/*": [
"packages/core/src/*"
],
"@theia/extension-manager/lib/*": [
"packages/extension-manager/src/*"
],
"@theia/filesystem/lib/*": [
"packages/filesystem/src/*"
],
Expand Down