[plug-in] memory: fix memory leak on plug-ins reload #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about the require.cache, it's not enough to only remove from cache: nodejs/node#8443 Change-Id: I690e82db53a0d8478ebe3f8b7b5d6fc59fe8a12e Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
added
bug
evidolob
approved these changes
Apr 17, 2019
azatsarynnyy
approved these changes
Apr 17, 2019
|
@akosyakov fine for you ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for eclipse-che/che-theia#120
about the require.cache cleanup, it was not enough to only remove entries from cache: nodejs/node#8443
After like 20 reloads we only have one occurence of the scripts bundled in the vsix:
Change-Id: I690e82db53a0d8478ebe3f8b7b5d6fc59fe8a12e
Signed-off-by: Florent Benoit fbenoit@redhat.com