Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin-Api] Add stub implementation of window.registerUriHandler() #5120

Merged
merged 1 commit into from
May 20, 2019

Conversation

vinokurig
Copy link
Contributor

Add stub implementation of the VsCode window.registerUriHandler() Api function.
Full implementation is going to be done in #5119
Is needed for eclipse-che/che#11867

@benoitf
Copy link
Contributor

benoitf commented May 17, 2019

hello, stub implementation should be avoided as much as possible now, when are you planning full implementation referenced by #5119 ?

@vinokurig
Copy link
Contributor Author

@benoitf Since Extend VsCode pull-request plugin (eclipse-che/che#10282) has the highest priority, we plan to start work on full implementation after eclipse-che/che#10282. This PR is needed to launch the VsCode pull-request plugin.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I don't see for browser mode how system-wide URI could be handled

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig vinokurig merged commit cfc6b36 into master May 20, 2019
@vinokurig vinokurig deleted the uriHandlerApi branch May 20, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants