Fix overriding preferences #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
May 15, 2019
| const overriddeValue = preferenceValue[overriddenPreferenceName]; | ||
| preferences[`${preferenceName}.${overriddenPreferenceName}`] = overriddeValue; | ||
| const overriddenValue = preferenceValue[overriddenPreferenceName]; | ||
| if (!preferences[`${preferenceName}`]) { |
There was a problem hiding this comment.
string interpolation is redundant then
akosyakov
previously requested changes
May 15, 2019
|
@akosyakov |
benoitf
approved these changes
May 17, 2019
27 tasks
svenefftinge
approved these changes
May 21, 2019
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
force-pushed
the
ab/fixPrevOverride
branch
from
59d7e09
to
a235f1c
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do
It turns out that when we have overridden preferences in a configuration file
AbstractResourcePreferenceProvidertransforms it into"[xml].editor.autoClosingBrackets" : "never"and it leads to that some extensions can't read these values.Debugging VS Code proved that it doesn't do this kind of transformation.
Reference issue
eclipse-che/che#12536