[plugin] [webview] Add min-height for webview icon as for other icons of tabs #5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I0e89d96052cd0b16073478f1d02ba9f309bd23e8 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
@jbicker ? |
|
Oups. Thanks for the reminder! Reviewing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-che/che-theia#174
webview icon was missing min-height after #4600
related to #4664 as well
https://github.com/theia-ide/theia/blob/4d74d28857cf994da063dac8672272d774c148b0/packages/core/src/browser/style/tabs.css#L136
before patch
after patch
Change-Id: I0e89d96052cd0b16073478f1d02ba9f309bd23e8
Signed-off-by: Florent Benoit fbenoit@redhat.com