Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show SCM repository icon in single project workspace #5304

Merged
merged 1 commit into from
May 29, 2019

Conversation

vinokurig
Copy link
Contributor

fixes #5300

@vinokurig vinokurig requested a review from akosyakov May 29, 2019 14:32
@@ -98,6 +98,9 @@ export class ScmContribution extends AbstractViewContribution<ScmWidget> impleme
});
this.scmService.onDidChangeSelectedRepositories(repository => {
if (repository) {
if (this.scmService.repositories.length === 1) {
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we explicitly remove CHANGE_REPOSITORY?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@akosyakov
Copy link
Member

akosyakov commented May 29, 2019

please remove inSingletonScope for ScmWidget in bindings, when a widget is removed it should be disposed and not kept in memory as now + we also should never inject ScmWidget but always get it from ScmContribution

Updated: moved it to #5306

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig vinokurig merged commit 6f164f7 into master May 29, 2019
@vinokurig vinokurig deleted the theia-5300 branch July 8, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[scm] repository picker in status bar should not be displayed for only one repo
2 participants