-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode clipboard api + support editor/title for webviews #5527
Conversation
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@502647092 could you test #5515, although i think first #5521 has to be resolved, otherwise webviews work really bogusly as for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried with https://marketplace.visualstudio.com/items?itemName=SirTobi.code-clip-ring extension and it's working fine
but as soon as I'm using Command+C and Chrome is asking me to authorize the clipboard, then the shortcut command+c is no longer working (while using Edit/copy is)
@akosyakov |
@502647092 I'm stuck with Monaco migration and don't have time to look at it for next 2 weeks for sure. I'm open to collaboration on it. If someone wants to take it over, please do. It can be additional commits in this PR or another PR against this. I don't care. cc @theia-ide/core |
@akosyakov I depend on Clipboard API support. Would you mind if I extract the related code from your PR to a separate one? |
@azatsarynnyy do it, although it does not work well enough, see #5527 (review) I hope you can find a way to improve it to support more browsers. |
This PR tries to address some issues of using humao.rest-client vscode extension.
How to test
Known issues