Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode clipboard api + support editor/title for webviews #5527

Closed
wants to merge 2 commits into from

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 19, 2019

This PR tries to address some issues of using humao.rest-client vscode extension.

How to test

  • install humao.rest-client extension
  • create test.http and type into some url
  • trigger a send request action
  • you should be able to toolbar actions
  • when you use them the clipboard should be properly populated (at least in Chrome and Electron)

Known issues

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

akosyakov commented Jun 19, 2019

@502647092 could you test #5515, although i think first #5521 has to be resolved, otherwise webviews work really bogusly as for now

@502647092
Copy link
Contributor

502647092 commented Jun 20, 2019

The toolbar has been displayed properly.

I don't know how to describe this problem. Maybe it's the plug-in problem.

temp

temp

@502647092
Copy link
Contributor

502647092 commented Jun 20, 2019

click webview will print error in console

temp

Uncaught TypeError: Cannot read property 'value' of null
    at getFoldingRangeEnd (VM755 main.js:105)
    at HTMLSpanElement.toggleLines (VM755 main.js:17)

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried with https://marketplace.visualstudio.com/items?itemName=SirTobi.code-clip-ring extension and it's working fine
but as soon as I'm using Command+C and Chrome is asking me to authorize the clipboard, then the shortcut command+c is no longer working (while using Edit/copy is)

clipboard

@502647092
Copy link
Contributor

@akosyakov
when will it be completed
i need it

@akosyakov
Copy link
Member Author

akosyakov commented Aug 16, 2019

@502647092 I'm stuck with Monaco migration and don't have time to look at it for next 2 weeks for sure. I'm open to collaboration on it. If someone wants to take it over, please do. It can be additional commits in this PR or another PR against this. I don't care. cc @theia-ide/core

@akosyakov akosyakov added clipboard issues related to the clipboard vscode issues related to VSCode compatibility webviews issues related to webviews labels Aug 16, 2019
@azatsarynnyy
Copy link
Member

@akosyakov I depend on Clipboard API support. Would you mind if I extract the related code from your PR to a separate one?

@akosyakov
Copy link
Member Author

akosyakov commented Aug 16, 2019

@azatsarynnyy do it, although it does not work well enough, see #5527 (review) I hope you can find a way to improve it to support more browsers.

@akosyakov
Copy link
Member Author

closing it, since it is superseded by #6030 and #5994

@akosyakov akosyakov closed this Sep 13, 2019
@akosyakov akosyakov deleted the GH-5515 branch January 3, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clipboard issues related to the clipboard vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] complete clipboard api [vscode] support editor/title context menus for web views
4 participants