always show debug icon on first start

[amiramw]

Align with vscode behavior.
See discussion: https://spectrum.chat/theia/dev/debug-icon-appearance~a321c3d1-11f4-45ec-a5ed-2d5e1ba2b714

Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com

[amiramw]

I'm getting this error in the build:

Error: Cannot find the log file for the Electron codecs test.
    at main (/Users/travis/build/theia-ide/theia/scripts/post-install.js:30:15)
    at Object.<anonymous> (/Users/travis/build/theia-ide/theia/scripts/post-install.js:34:1)

Anyone has any clue?

[kittaakos]

Anyone has any clue?

CC: @marechal-p

[vince-fugnitto]

@amiramw can you rebase your PR on master, hopefully it's fixed by #5587

[amiramw]

now appveyor fail with unrelated error...

[vince-fugnitto]

@amiramw I'm just curious, initially we had your change, but then it was updated to the following c52e20f. It looks like the PR intended to only show the debug view if there were currently supported debug configurations. Perhaps we should check thoroughly why the change was needed before we revert to the original design.

[amiramw]

@akosyakov could you advise maybe why was this check added and whether it is ok not to have it? In vscode the debug icon is visible even though there are not configurations.

[akosyakov]

We don't want to confuse a user that debugging is supported if there is no debug adapter available for his project, i.e. debug extension is installed, but no concrete debuggers. I'm not sure how to go about it. Maybe it would be better never show it by default, but concrete IDEs can enable it. cc @svenefftinge

Agreed though that configurations check is not good way to detect debug adapter support.

[akosyakov]

@svenefftinge Could we just enable it always?

[svenefftinge]

Yes, I think we can align it now, given that our vs code extension support has been improved a lot lately.

[akosyakov]

the debug view is there by default, @amiramw thank you!