Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Updated the Node.js prerequisites. #5643

Merged
merged 1 commit into from
Jul 5, 2019
Merged

[doc] Updated the Node.js prerequisites. #5643

merged 1 commit into from
Jul 5, 2019

Conversation

kittaakos
Copy link
Contributor

Node.js 12.x is not yet supported.

Signed-off-by: Akos Kitta kittaakos@typefox.io

Node.js 12.x is not yet supported.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos requested a review from marcdumais-work July 4, 2019 13:59
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the updates, only minor comment is the AND looks a little strong capitalized (and would probably be fine), but I know we want to strongly emphasize the version range.

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kittaakos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants