Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'theia-widget-noInfo' css class to fix message inconsistencies #5717

Merged
merged 1 commit into from
Jul 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class CallHierarchyTreeWidget extends TreeWidget {

protected renderTree(model: TreeModel): React.ReactNode {
return super.renderTree(model)
|| <div className='noCallers'>No callers have been detected.</div>;
|| <div className='theia-widget-noInfo'>No callers have been detected.</div>;
}

protected renderCaption(node: TreeNode, props: NodeProps): React.ReactNode {
Expand Down
4 changes: 0 additions & 4 deletions packages/callhierarchy/src/browser/style/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
padding-right: 4px;
}

.theia-CallHierarchyTree .noCallers {
margin: 5px 19px;
}

.theia-CallHierarchyTree .definitionNode {
display: flex;
}
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/browser/style/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,4 @@ textarea {
@import './notification.css';
@import './alert-messages.css';
@import './icons.css';
@import './widget.css';
19 changes: 19 additions & 0 deletions packages/core/src/browser/style/widget.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/********************************************************************************
* Copyright (C) 2019 Ericsson and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0 which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the Eclipse
* Public License v. 2.0 are satisfied: GNU General Public License, version 2
* with the GNU Classpath Exception which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
********************************************************************************/

.theia-widget-noInfo {
padding: calc(var(--theia-ui-padding) * 2);
}
2 changes: 1 addition & 1 deletion packages/markers/src/browser/problem/problem-widget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class ProblemWidget extends TreeWidget {
if (MarkerRootNode.is(model.root) && model.root.children.length > 0) {
return super.renderTree(model);
}
return <div className='noMarkers'>No problems have been detected in the workspace so far.</div>;
return <div className='theia-widget-noInfo noMarkers'>No problems have been detected in the workspace so far.</div>;
}

protected renderCaption(node: TreeNode, props: NodeProps): React.ReactNode {
Expand Down
4 changes: 0 additions & 4 deletions packages/markers/src/browser/style/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
color: var(--theia-ui-font-color1);
}

.theia-marker-container .noMarkers {
padding: 5px;
}

.theia-side-panel .theia-marker-container .noMarkers {
padding-left: 19px;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/outline-view/src/browser/outline-view-widget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class OutlineViewWidget extends TreeWidget {

protected renderTree(model: TreeModel): React.ReactNode {
if (CompositeTreeNode.is(this.model.root) && !this.model.root.children.length) {
return <div className='no-outline'>No outline information available.</div>;
return <div className='theia-widget-noInfo no-outline'>No outline information available.</div>;
}
return super.renderTree(model);
}
Expand Down
1 change: 0 additions & 1 deletion packages/outline-view/src/browser/styles/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

.no-outline {
color: var(--theia-ui-font-color0);
padding: 10px;
text-align: left;
}

Expand Down