Register the current EditorTheme and retrigger monaco tokenizing #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbicker
force-pushed
the
start-with-correct-default-theme
branch
from
141f874 to
ca43970
Compare
akosyakov
reviewed
Jul 16, 2019
packages/monaco/src/browser/textmate/monaco-textmate-service.ts
Outdated
Show resolved
Hide resolved
akosyakov
reviewed
Jul 16, 2019
packages/monaco/src/browser/textmate/monaco-textmate-service.ts
Outdated
Show resolved
Hide resolved
|
Just to sum up: the root cause was a race condition between updating textmate and monaco themes. Sometimes monaco theme will be updated before leading to coloring a file with an old theme. Now textmate should be updated before monaco theme. Funny effect was that a file could end up be highlighted partially by old and new themes if an update of a textmate theme happens while monaco still running tokenization. |
...initially and after theme changed. Additionally remove old css theme class from body. Fixes #4550 Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
jbicker
force-pushed
the
start-with-correct-default-theme
branch
from
ca43970 to
62d1e5c
Compare
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...initially and after theme changed.
Additionally remove old css theme class from body.
Fixes #4550
As a test one should add a default theme to package.json different fro the dark theme.
Thanks a lot to @akosyakov for helping with this fix!!!