[vscode] unzip node_modules for built-in extensions #5771
Conversation
| @@ -41,6 +42,13 @@ export class PluginVsCodeFileHandler implements PluginDeployerFileHandler { | |||
|
|
|||
| const unpackedPath = path.resolve(this.unpackedFolder, path.basename(context.pluginEntry().path())); | |||
| await context.unzip(context.pluginEntry().path(), unpackedPath); | |||
| if (context.pluginEntry().path().endsWith('.tgz')) { | |||
| const extensionPath = path.join(unpackedPath, 'package'); | |||
| const vscodeNodeModulesPath = path.join(extensionPath, 'vscode_node_modules.zip'); | |||
There was a problem hiding this comment.
built-in extensions are already republished with zip for node modules: eclipse-theia/vscode-builtin-extensions@51e5e27#diff-1b65ea7e7a9dd6aa50436ecdd461f0aaR23
|
hello, why published file is not a vsix file ? |
Because npm does not accept such formats? Or do you mean package everything into vsix then push it to npm and then unpackage twice in Theia first from npm then from vsix? We could it do like that as well if someone will do it today. I don't have time to look at it. |
|
testing right now... |
|
@akosyakov yes I mean embedding the vsix file inside the tgz archive so at the end we just deploy vsix files, not a custom archive |
|
@benoitf Would it be fine to file an issue for it for now? There are probably would be gotchas since VS Code team does not package these extensions, some attributes or files could be missing and so on. |
|
If no one is going to propose a PR with an alternative approach, we are going to merge it tomorrow. |
akosyakov
added
critical
|
I'm fine. Also maybe we should release these vsix on github release page instead of npmjs |
|
@benoitf an issues is here: eclipse-theia/vscode-builtin-extensions#5 |
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
What it does
fix #5756: unzip node_modules for built-in extensions
How to test
Review checklist
Reminder for reviewers