Ensure terminate flags restart when restarting

[thegecko]

Signed-off-by: Rob Moran rob.moran@arm.com

What it does

This PR ensures that the restart flag is always set to true when sending a terminate command to a debug adapter during a restart. The default is false.

This could also be fixed by passing true at the end of this function call, but I can't think of any situation where this flag should be set to false during a restart.

I'm also not sure what the config state is saving here, this change may make it redundant?

How to test

Implement terminateRequest() in a debug adapter and observe that restart in the arguments has the value true during a restart.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

It looks correct to me as well, checking that it does not cause issues with node.js debugging

[akosyakov]

It seems to work well with Node.js extension or maybe even better now since the proper value is passed 😊

[tolusha]

I checked how restart working with c++ debugger and didn't find any regressions.