support array and object schemas of configuration contribution point #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
approved these changes
Aug 30, 2019
tom-shan
commented
Aug 31, 2019
| contributions.configuration = config; | ||
| const config = rawPlugin.contributes.configuration; | ||
| if (config) { | ||
| contributions.configuration = this.readConfiguration(Array.isArray(config) ? config[0] : config, rawPlugin.packagePath); |
There was a problem hiding this comment.
It's better to merge the config array if it contains more than one element.
I will update this PR.
fix eclipse-theia#6072 plugin system should support array and object schemas of configuration contribution point Signed-off-by: tom-shan <swt0008411@163.com>
tom-shan
force-pushed
the
plugin-contribution
branch
from
d595aa2 to
d5de664
Compare
|
Hey @tom-shan sorry I didn't see this PR earlier and worked on the same thing... Could you please update your PR (or close it and we go with #6078)? |
|
@svenefftinge That's all right. For your implementation is better, let's go with your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6072
The plugin system should support array and object schemas for configuration contribution points.
How to test
File>Settings>Open Preferences3.1.
tomcat.workspace3.2.
tomcat.restart_when_http(s)_port_changeReview checklist
Reminder for reviewers