Give React tab toolbar items access to the current widget instance #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows toolbar items to show content specific to the current widget. For example, a toolbar item for the terminal could show a message specific to the currently displayed terminal tab. Signed-off-by: Matthew Gordon <matthew.gordon@arm.com>
|
@svenefftinge thanks for the review, I've updated as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR passes the current widget to the render method of React tab bar toolbar items.
This allows extension authors to create toolbar items that show content specific to the current widget instance. This is useful when there can be more instance of a Widget class at a time. For example, a toolbar item for the terminal could show a message specific to the currently displayed terminal tab.
This change brings the signature for
renderin to line withisVisible: https://github.com/eclipse-theia/theia/blob/master/packages/core/src/browser/shell/tab-bar-toolbar.tsx#L297.How to test
Add a tab toolbar item with a render method that uses the input widget. Test that the item content changes appropriately as different widgets are selected.
See https://github.com/mcgordonite/theia/commit/d713b49d977a5835ca55c00acd489e449100881b.
Review checklist
Reminder for reviewers