-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve plugins loading #6267
improve plugins loading #6267
Conversation
Metadata for many plugins accumulate to a single message over 5Mb big which blocks web socket, compressing such message helps to reduce blocking time. Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
Instead of sending it first to the plugin host and then back to the frontend. Debug metadata are big fetching them to the client, then sending back to the plugin host and fetching again is expensive and blocking web socket. Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
Instead of sending all intiailzation data on each plugin deployment. It is unnecessary and leads to sending big chunks of data, e.g. all preference values, each time. Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
Before on each deployment the entire metdata will be loaded again. It was expensive, since metadata is big with a lot of plugins and unnecessary as well. Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
With multiple windows there were duplicate log entries. Now each log entry has a unique uuid to identify a window. Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
In order to see performance improvement now and spot degradation later. Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
Before a grammar won't be activated for an opened editor after reload because we missed language activation event. Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
hello, why do we have yet another PR than #6252 ? |
@benoitf no, I follow your suggestions, from #6252 (comment):
Or you are going to review changes to mentioned 2 commits? |
@akosyakov I will review the two commits |
for me this PR is fine but it is not solving all the issues, so I would better use #6252 |
I don't see yellow status bar with this PR as well, but numbers on 3G are not so good as with #6252
|
I'd prefer to go with #6252, too. |
Closing since #6252 is merged. |
What it does
How to test
plugins
folder:https://drive.google.com/file/d/1tuOsorMVOKi_twL9oAuZxgrD7-VUwNsj/view?usp=sharing
Review checklist
Reminder for reviewers