Pass pluginInfo through to output channel append method #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
1 task
| @@ -991,7 +991,7 @@ export interface PreferenceRegistryExt { | |||
| } | |||
|
|
|||
| export interface OutputChannelRegistryMain { | |||
| $append(channelName: string, value: string): PromiseLike<void>; | |||
| $append(channelName: string, value: string, pluginInfo: PluginInfo): PromiseLike<void>; | |||
There was a problem hiding this comment.
In general, I have two comments:
- should we make
pluginInfooptional? - should it simply be in the form of
options? anyso we can potentially pass more in the future?
There was a problem hiding this comment.
Technically we could make it optional, but I was just following what I did in: f25652a
akosyakov
approved these changes
Oct 3, 2019
|
@akosyakov Is it okay to merge or should we wait for @evidolob and @benoitf to take a look |
|
@JPinkney it is fine with me to merge |
|
you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What it does
This PR passes the pluginInfo through to the output-channel-registry-main $append method.
This is needed for https://github.com/eclipse-theia/theia/pull/6303/files#r330382601 to make the language plugins we can get metrics from more dynamic.
How to test
Put a breakpoint https://github.com/eclipse-theia/theia/compare/master...JPinkney:pass-plugin-info-output-registry?expand=1#diff-11ebe3cff728b3126a471050a7378864L37 and launch the browser backend/frontend. Then install vscode java. When it's installed and starts outputting to the output channel the breakpoint will be hit. Inspect the pluginInfo variable and you will find the pluginInfo that was passed through.
Review checklist
Reminder for reviewers