[terminal] Move hover tooltip zIndex above the xterm.js canvas layers #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Keromnes <jan.keromnes@typefox.io>
vince-fugnitto
approved these changes
Oct 3, 2019
|
@jankeromnes is not a committer @vince-fugnitto please help with merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Currently, the link
Cmd + clicktooltip appears behind the Xterm canvas border:That's because it has a
z-indexof1, while Xterm canvas layers havez-indexes of0,1,2and3.In this Pull Request, I've set the tooltip
z-indexto10, which makes it appear above the Xterm canvas border:How to test
Review checklist
Reminder for reviewers