Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned the default message with VS Code #6345

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Conversation

kittaakos
Copy link
Contributor

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

Aligns the default notification center title with VS Code. I do not know if this is needed at all, if no, please close the PR.

VS Code:
Screen Shot 2019-10-08 at 10 26 55

Theia:
Screen Shot 2019-10-08 at 10 33 50

How to test

Open the notification center in Theia when there are no new notifications.

Review checklist

Reminder for reviewers

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos requested a review from AlexTugarev October 8, 2019 08:35
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kittaakos!

@kittaakos kittaakos merged commit fcccdf4 into master Oct 8, 2019
@kittaakos kittaakos deleted the notification-center-msg branch October 8, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants