[vscode] support globalStoragePath
#6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svenefftinge how did you get the git graph extension working? |
|
I did not. Webviews are not really supported by theia atm. |
|
I see so the check is to see if any error is logged related to this. |
|
checked with current master. the extension fails to activate because |
AlexTugarev
reviewed
Oct 9, 2019
svenefftinge
force-pushed
the
se/globalStoragePath
branch
from
a157652 to
e7bb225
Compare
AlexTugarev
reviewed
Oct 10, 2019
| } | ||
| return globalStorage; | ||
| } | ||
| const globalStoragePath = join(configStorage.hostGlobalStoragePath || (await defaultGlobalStorage()), plugin.model.id); |
There was a problem hiding this comment.
e.g.~/.theia/globalStorage/mhutchie.git-graph
I think this fine now, thanks!
AlexTugarev
reviewed
Oct 10, 2019
| @@ -266,6 +268,18 @@ export class PluginManagerExtImpl implements PluginManagerExt, PluginManager { | |||
| const asAbsolutePath = (relativePath: string): string => join(plugin.pluginFolder, relativePath); | |||
| const logPath = join(configStorage.hostLogPath, plugin.model.id); // todo check format | |||
| const storagePath = join(configStorage.hostStoragePath || '', plugin.model.id); | |||
| async function defaultGlobalStorage(): Promise<string> { | |||
| const homeTheia = join(os.homedir(), '.theia'); | |||
| if (!(await fs.pathExists(homeTheia))) { | |||
There was a problem hiding this comment.
there is a short cut for this in fs-extra: fs.ensureDir(join(os.homedir(), '.theia', 'globalStorage'))
AlexTugarev
approved these changes
Oct 10, 2019
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
force-pushed
the
se/globalStoragePath
branch
from
e7bb225 to
59e3a06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Added
globalStoragePathto the ExtensionContext object.How to test
Install an extension that accesses this property (e.g. git graph).
Review checklist
Reminder for reviewers