Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6380: Add configuration attribute to DebugSession #6382

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

BroKun
Copy link
Member

@BroKun BroKun commented Oct 14, 2019

Signed-off-by: Brokun brokun0128@gmail.com

What it does

Add configuration attribute to DebugSession

How to test

  1. Add the latest version of the vscode-python plugin
  2. Debugging Python files

Review checklist

Since I only know that the vscode-python plugin uses related APIs, I have not tested the performance of other plugins.

Reminder for reviewers

@BroKun BroKun changed the title Add configuration attribute to DebugSession Fix#6380: Add configuration attribute to DebugSession Oct 14, 2019
Signed-off-by: Brokun <brokun0128@gmail.com>
@BroKun BroKun changed the title Fix#6380: Add configuration attribute to DebugSession Fix #6380: Add configuration attribute to DebugSession Oct 14, 2019
@akosyakov akosyakov added debug issues that related to debug functionality vscode issues related to VSCode compatibility labels Oct 15, 2019
@akosyakov akosyakov requested a review from tolusha October 15, 2019 05:30
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify that debugging with latest version of vscode-python does not work on master, but works with this PR:

  • ext install ms-python.python - to install latest extension
  • Launch configuration:
    {
      "name": "Python: Current File",
      "type": "python",
      "request": "launch",
      "program": "${file}",
      "console": "internalConsole",
      "internalConsoleOptions": "openOnSessionStart"
    }
  • Test file:
x = 1
if x == 1:
    # indented four spaces
    print("x is 1.")

BTW I've noticed that we also missing workspaceFolder attribute on DebugSession. Please file a a follow-up issue we have to complete this api.

@BroKun
Copy link
Member Author

BroKun commented Oct 15, 2019

I added #6385 @akosyakov

@BroKun
Copy link
Member Author

BroKun commented Oct 15, 2019

There is nothing left, could I operate the merger myself? @akosyakov

@akosyakov
Copy link
Member

@BroKun yes, sure, you are committer

@BroKun BroKun merged commit e711949 into eclipse-theia:master Oct 15, 2019
@BroKun BroKun deleted the GH-6380 branch October 15, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants