-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpp] remove '@theia/cpp' extension #6505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link provided #69 is not pointing to eclipse-theia/theia-cpp-extensions#69
Result from testing:
yarn test:
lerna success run Ran npm script 'test' in packages:
lerna success - @theia/example-browser
Done in 392.57s.
Rebase: May need a manual intervention
Merge: conflict with "packages/cpp/src/browser/cpp-task-provider.ts"
Version master of packages/cpp/src/browser/cpp-task-provider.ts left in tree.
Automatic merge failed; fix conflicts and then commit the result.
Even if approved, should only merge to master branch after eclipse-theia/theia-cpp-extensions#69 has been merged.
a35f131
to
4f82be4
Compare
@lmcbout I resolved the merge conflict :) |
@vince-fugnitto The wait for the other PR to be merged is to let the end-user have the alternative ready to use before we cut the CPP support, Just to be nice to all users. |
I just need someone to approve the PR from |
Fixes #6340 - removes the `@theia/cpp` extension. - removes references to the `@theia/cpp` extension. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
4f82be4
to
0bab5be
Compare
Any plans to merge it? Any removed extension makes our build faster. |
Yes, just waiting for eclipse-theia/theia-cpp-extensions#69. |
Merging! :) |
What it does
Fixes #6340
The
@theia/cpp
extension is planned to move to theia-cpp-extensions repository.The pull request has already been started: eclipse-theia/theia-cpp-extensions#69
This PR:
@theia/cpp
extension.@theia/cpp
extension.How to test
Review checklist
@theia/cpp
is merged into theia-cpp-extensionsReminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com