Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp] remove '@theia/cpp' extension #6505

Merged
merged 1 commit into from
Nov 18, 2019
Merged

[cpp] remove '@theia/cpp' extension #6505

merged 1 commit into from
Nov 18, 2019

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Nov 6, 2019

What it does

Fixes #6340

The @theia/cpp extension is planned to move to theia-cpp-extensions repository.
The pull request has already been started: eclipse-theia/theia-cpp-extensions#69

This PR:

  • removes the @theia/cpp extension.
  • removes references to the @theia/cpp extension.

How to test

  • verify that CI passes successfully
  • verify that the application correctly starts

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added the cpp issues related to the C/C++ language label Nov 6, 2019
@vince-fugnitto vince-fugnitto self-assigned this Nov 6, 2019
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link provided #69 is not pointing to eclipse-theia/theia-cpp-extensions#69

Result from testing:
yarn test:

lerna success run Ran npm script 'test' in packages:
lerna success - @theia/example-browser
Done in 392.57s.

Rebase: May need a manual intervention

Merge: conflict with "packages/cpp/src/browser/cpp-task-provider.ts"
Version master of packages/cpp/src/browser/cpp-task-provider.ts left in tree.
Automatic merge failed; fix conflicts and then commit the result.

Even if approved, should only merge to master branch after eclipse-theia/theia-cpp-extensions#69 has been merged.

@vince-fugnitto
Copy link
Member Author

@lmcbout I resolved the merge conflict :)
I don't believe there is an explicit need to wait for the theia-cpp-extensions pr to be merged first however.

@lmcbout
Copy link
Contributor

lmcbout commented Nov 11, 2019

@vince-fugnitto The wait for the other PR to be merged is to let the end-user have the alternative ready to use before we cut the CPP support, Just to be nice to all users.

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto The wait for the other PR to be merged is to let the end-user have the alternative ready to use before we cut the CPP support, Just to be nice to all users.

I just need someone to approve the PR from theia-cpp-extensions then :)

Fixes #6340

- removes the `@theia/cpp` extension.
- removes references to the `@theia/cpp` extension.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@akosyakov
Copy link
Member

Any plans to merge it? Any removed extension makes our build faster.

@vince-fugnitto
Copy link
Member Author

Any plans to merge it? Any removed extension makes our build faster.

Yes, just waiting for eclipse-theia/theia-cpp-extensions#69.
I believe internally we are using eclipse-theia/theia-cpp-extensions#69 this week for a demo so it will likely be merged the beginning of next week. @marcdumais-work

@vince-fugnitto
Copy link
Member Author

Merging! :)

@vince-fugnitto vince-fugnitto merged commit 3652029 into master Nov 18, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6340 branch November 18, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp issues related to the C/C++ language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cpp] plan to move the 'cpp' extension into 'theia-cpp-extensions' repo
3 participants