Fix Task.execution instantiation

[tolusha]

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What it does

Fix Task.execution instantiation.
ShellExecution and ProcessExecution contain additional logic in their constructors.
That's why is it necessary to use them.

[1] https://github.com/theia-ide/theia/blob/ab/fixTaskExecution/packages/plugin-ext/src/plugin/types-impl.ts#L1461
[2] https://github.com/eclipse-theia/theia/blob/ab/fixTaskExecution/packages/plugin-ext/src/plugin/types-impl.ts#L1368

How to test

The following tasks should work:

1. https://github.com/tolusha/vscode-test-extensions/blob/master/task-test-0.0.1.vsix?raw=true

{
    // comment
    "tasks": [
        {
            "label": "config_task#1",
            "type": "shell",
            "command": "echo",
            "args": [
                "test"
            ]
        },
        {
            "label": "config_task#2",
            "type": "shell",
            "command": "echo test"
        }        
    ]
}

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[tolusha]

@eclipse-theia/task-extension

[RomanNikitenko]

Looks like tests for converting failed:

[RomanNikitenko]

The function takes TaskDto now, so unnecessary assertion in the place of call

[RomanNikitenko]

Please see https://github.com/eclipse-theia/theia/pull/6533/files#r345217054

[RomanNikitenko]

@tolusha
Sorry, but I think that for testing your PR it's not enough just to run tasks with type process and shell.

The changes are related to plugin system, so I would say that it's very important to test the changes using some plugin (with task resolver I guess, as a resolver uses converting mechanism).

I tested your changes for che tasks and unfortunately they are broken.
Are you going to provide the corresponding PR to che-theia to adapt execution of che tasks?

[tolusha]

@RomanNikitenko
I've pushed a corresponding fix into https://github.com/eclipse/che-theia/tree/ab/fixTaskExecution
Could you check pls?

[RomanNikitenko]

@tolusha
Thank you, I'm going to test your changes today

[RomanNikitenko]

@tolusha
I tested your changes, after last update it works well for che tasks.
Do you know some VS Code extension/custom plugin to test it for theia project?

thanks in advance!

[tolusha]

It is ready to test.
See How to testsection.
@eclipse-theia/task-extension

[RomanNikitenko]

I tested the changes:

• 3 detected tasks provided by the test extension from the PR description
  and
• che tasks

work well for me!

[akosyakov]

@tolusha @RomanNikitenko @elaihau Can this PR affect built-in VS Code extensions like npm, gulp, grant and so on? I just don't see that anyone tested against them. If you think that it is not necessary and you are sure everything is alright please go ahead to merge.

[RomanNikitenko]

To be honest, I don't know which VS Code extension would be good for testing these changes.
I'll try it for tsc and npm tasks today and give the feedback, but it still question for me about the relevant VS Code extension for testing...

[RomanNikitenko]

I tested npm build and watch tasks.
These tasks have type: 'shell' in the definition and commandLine in the shellExecution(if I understand correctly, the PR changes target is fix for converting shell tasks with commandLine).

So, I checked that at converting the configurations:

• fromTask they have, for example, commandLine: 'npm run build'(from plugin side to theia configuration)
• toTask method returns commandLine: 'npm run build' (from theia configuration to plugin config)

Looks good to me and I can run these configurations using the PR changes.

[akosyakov]

To be honest, I don't know which VS Code extension would be good for testing these changes.
I'll try it for tsc and npm tasks today and give the feedback, but it still question for me about the relevant VS Code extension for testing...

I hope you and @elaihau become experts in this area :) please merge, i don't think we will get better opinion