Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix 'noWrapInfo' CSS class #6593

Merged
merged 1 commit into from
Nov 29, 2019
Merged

[core] fix 'noWrapInfo' CSS class #6593

merged 1 commit into from
Nov 29, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #6592

  • fixes the issue where noWrapInfo is referenced in core
    without actually having its CSS defined. The noWrapInfo is currently
    available from other extensions, and if those extensions are not included
    the styling is off.
  • removes duplication of CSS properties.

How to test

  • verify that previous uses (extensions) of noWrapInfo are styled correctly.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Nov 20, 2019
@vince-fugnitto vince-fugnitto self-assigned this Nov 20, 2019
Fixes #6592

- fixes the issue where `noWrapInfo` is referenced in `core`
without actually having its CSS defined. The `noWrapInfo` is currently
available from other extensions, and if those extensions are not included
the styling is off.
- removes duplication of CSS properties.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@elaihau
Copy link
Contributor

elaihau commented Nov 27, 2019

I understand what this change does however I am unable to reproduce what #6592 (comment) shows (on master branch) ... am i missing something?

Peek 2019-11-26 23-43

@lmcbout
Copy link
Contributor

lmcbout commented Nov 27, 2019

Same a @elaihau I cannot reproduce this issue with and without this PR.
I used the latest commit: 0f16fe8
The File explorer is not wrapping. Am I missing something as well for testing ?

@vince-fugnitto
Copy link
Member Author

vince-fugnitto commented Nov 27, 2019

@elaihau @lmcbout as described in the issue ( #6592), the problem occurs in a minimal application, for example the theia-cpp-extensions. If you build and test that repo, you will notice the error that is being fixed with the PR.


Update

Here is the bug with the explorer for the theia-cpp-extensions example app:

Screen Shot 2019-11-27 at 7 42 43 AM

@elaihau
Copy link
Contributor

elaihau commented Nov 28, 2019

could you please define "minimal application" @vince-fugnitto ? Thank you !

@vince-fugnitto
Copy link
Member Author

could you please define "minimal application" @vince-fugnitto ? Thank you !

I tested using the theia-cpp-extensions example application, but a minimal application means an app that did not have as dependencies the extensions as part of the changed files. (ex: search-in-workspace)

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Vincent's help I am able to reproduce the problem.

I tested it with theia-cpp-extensions and the change worked. Also, I don't see the change break the example-browser of theia.

@vince-fugnitto vince-fugnitto merged commit 693ea38 into master Nov 29, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6592 branch November 29, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] css class 'noWrapInfo' is referenced in 'core' without being defined
3 participants