-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix 'noWrapInfo' CSS class #6593
Conversation
Fixes #6592 - fixes the issue where `noWrapInfo` is referenced in `core` without actually having its CSS defined. The `noWrapInfo` is currently available from other extensions, and if those extensions are not included the styling is off. - removes duplication of CSS properties. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
de7690c
to
2a33414
Compare
I understand what this change does however I am unable to reproduce what #6592 (comment) shows (on master branch) ... am i missing something? |
@elaihau @lmcbout as described in the issue ( #6592), the problem occurs in a minimal application, for example the theia-cpp-extensions. If you build and test that repo, you will notice the error that is being fixed with the PR. Update Here is the bug with the explorer for the |
could you please define "minimal application" @vince-fugnitto ? Thank you ! |
I tested using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Vincent's help I am able to reproduce the problem.
I tested it with theia-cpp-extensions
and the change worked. Also, I don't see the change break the example-browser of theia.
What it does
Fixes #6592
noWrapInfo
is referenced incore
without actually having its CSS defined. The
noWrapInfo
is currentlyavailable from other extensions, and if those extensions are not included
the styling is off.
How to test
noWrapInfo
are styled correctly.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com