Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move json grammar to textmate-grammars package #6622

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Move json grammar to textmate-grammars package #6622

merged 1 commit into from
Nov 25, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 25, 2019 •
edited
Loading

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What it does

PR moves json grammar to textmate-grammars package.

How to test

  • open any json file, check if syntax highlighting works

Review checklist

Reminder for reviewers

@tolusha
Move json grammar to textmate-grammars package
54fee05 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha added textmate issues related to the textmate grammars json issues related to the json language labels Nov 25, 2019
@tolusha tolusha self-assigned this Nov 25, 2019
svenefftinge
svenefftinge approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf mentioned this pull request Nov 25, 2019
Closed
14 tasks
@tolusha tolusha merged commit 797d03b into master Nov 25, 2019
@tolusha tolusha deleted the ab/jsongrammar branch November 25, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@akosyakov akosyakov Awaiting requested review from akosyakov

Assignees

@tolusha tolusha

Labels
json issues related to the json language textmate issues related to the textmate grammars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tolusha @svenefftinge