Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keybinding] Align more Electron/browser keybindings with VS Code #6635

Merged
merged 3 commits into from
Dec 1, 2019
Merged

[keybinding] Align more Electron/browser keybindings with VS Code #6635

merged 3 commits into from
Dec 1, 2019

Conversation

jankeromnes
Copy link
Member

@jankeromnes jankeromnes commented Nov 26, 2019 •
edited
Loading

What it does

How to test

Review checklist

Reminder for reviewers

@jankeromnes jankeromnes force-pushed the jx/keybindings branch 2 times, most recently from 247fecf to 1bcb638 Compare November 26, 2019 15:24
@jankeromnes jankeromnes mentioned this pull request Nov 27, 2019
Closed
@jankeromnes jankeromnes changed the title [WIP][keybinding] Align more Electron/browser keybindings with VS Code [keybinding] Align more Electron/browser keybindings with VS Code Nov 27, 2019
@jankeromnes jankeromnes marked this pull request as ready for review November 27, 2019 10:56
@jankeromnes
Copy link
Member Author

jankeromnes commented Nov 27, 2019 •
edited
Loading

Summary of relevant keybindings in VS Code:

VS Code Windows Mac OS Linux
New File Ctrl + N Cmd + N Ctrl + N
Close Editor Ctrl + F4 Cmd + W Ctrl + W
Close Window Ctrl + W Shift + Cmd + W Ctrl + Q

Summary of keybindings in Theia with this PR:

Theia (Electron) Windows Mac OS Linux
New File Ctrl + N Cmd + N Ctrl + N
Close Editor Ctrl + F4 Cmd + W Ctrl + W
Close Window Ctrl + W Shift + Cmd + W Ctrl + Q
Theia (browser) Windows Mac OS Linux
New File Alt + N Opt + N Alt + N
Close Editor Alt + W Opt + W Alt + W
Close Window Ctrl + W Cmd + W Ctrl + W

@akosyakov akosyakov added the keybindings issues related to keybindings label Nov 28, 2019
@unknowndomain unknowndomain mentioned this pull request Nov 29, 2019
Closed
3 tasks
@jankeromnes
Copy link
Member Author

jankeromnes commented Nov 29, 2019 •
edited
Loading

Let's tackle Ctrl/Cmd + O in a follow-up PR, so that we can move forward here.

@jankeromnes
Copy link
Member Author

jankeromnes commented Nov 29, 2019 •
edited
Loading

I didn't actually test on Linux, nor on Electron Windows yet, but this is ready for review.

EDIT: Now tested on Linux, works fine too. (I forgot that Theia's Gitpod setup had VNC! That was easy.)

@jankeromnes
[keybinding] Add 'New File' keybinding ('ctrlcmd+n' in Electron, 'alt…
2e049a8 
…+n' in browser)

Signed-off-by: Jan Keromnes <jan.keromnes@typefox.io>
@jankeromnes
[keybinding] Align 'Close Window' keybinding with VS Code across OSes
ee1dd13 
Signed-off-by: Jan Keromnes <jan.keromnes@typefox.io>
@jankeromnes
[keybinding] Align 'Close Editor' keybinding with VS Code across OSes
3e41eb8 
Signed-off-by: Jan Keromnes <jan.keromnes@typefox.io>
@jankeromnes
Copy link
Member Author

Thank you Sven! Please also merge the PR if you have time, since I can't do that myself yet.

@svenefftinge svenefftinge merged commit c4b4d39 into eclipse-theia:master Dec 1, 2019
@jankeromnes jankeromnes deleted the jx/keybindings branch December 4, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

Assignees
No one assigned
Labels
keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankeromnes @svenefftinge @akosyakov