Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electron] Use VS Code's keychord for the 'Close All' command #6703

Merged
merged 1 commit into from
Dec 6, 2019
Merged

[electron] Use VS Code's keychord for the 'Close All' command #6703

merged 1 commit into from
Dec 6, 2019

Conversation

kittaakos
Copy link
Contributor

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

Closes the editors widgets in the 'main' area with VS Code's keychord if running in electron environment.
The new binding is: Ctrl/Cmd+K | Ctrl/Cmd+W.

close-all-electron

How to test

Review checklist

Reminder for reviewers

@kittaakos kittaakos changed the title Use VS Code's key-chord for closing all editors. [electron] Use VS Code's key-chord for closing all editors. Dec 6, 2019
@akosyakov akosyakov added the electron issues related to the electron target label Dec 6, 2019
vince-fugnitto
vince-fugnitto approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me :) (I'm also used to the command from VS Code)

  • [minor] I'm not sure if we want to update the commit message to reflect that not only editors are closed with this command but all widgets present in the main area.

Use VS Code's keychord for the 'Close All' command
dd1033e 
When the app is running in the electron environment.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos
Copy link
Contributor Author

  • update the commit message

Done: dd1033e

@kittaakos kittaakos changed the title [electron] Use VS Code's key-chord for closing all editors. [electron] Use VS Code's keychord for the 'Close All' command Dec 6, 2019
@kittaakos kittaakos merged commit d9800b4 into master Dec 6, 2019
@kittaakos kittaakos deleted the close-all-electron branch December 6, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

Assignees
No one assigned
Labels
electron issues related to the electron target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @vince-fugnitto @akosyakov