Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markers] add problems statusbar tooltip #6771

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

  • adds a tooltip to the problems statusbar when hovering over the item.
  • displays No Problems when no problems are present.
  • displays the count and type of a problem for each problem stat property when problems are present.

How to test

  • verify the problem statusbar item tooltip for a collection of different scenarios:
    • multiple errors, warnings, infos
    • no errors

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

- adds a tooltip to the problems statusbar when hovering over the item.
- displays `No Problems` when no problems are present.
- displays the count and type of a problem for each problem stat property when problems are present.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added markers issues related to problem markers statusbar issues related to the statusbar labels Dec 18, 2019
@vince-fugnitto vince-fugnitto self-assigned this Dec 18, 2019
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise :ok
Tested on Ubuntu OK
One comment: Since we don't display the "Hints" on the status bar, should we display the "Hint" with the info, ... on the tooltip ?

@vince-fugnitto
Copy link
Member Author

Code wise :ok
Tested on Ubuntu OK
One comment: Since we don't display the "Hints" on the status bar, should we display the "Hint" with the info, ... on the tooltip ?

I initially simply followed the behavior present in VS Code (which both does not display hints).
I think the addition of hints would be a bit too noisy and the interface ProblemStat would need to be updated and in other places as well if we were to simply display them.

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in Gitpod. Thank you for the change.

@vince-fugnitto
Copy link
Member Author

Thank you @lmcbout @elaihau !

@vince-fugnitto vince-fugnitto merged commit 928a194 into master Dec 20, 2019
@vince-fugnitto vince-fugnitto deleted the vf/problems-statusbar branch December 20, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers issues related to problem markers statusbar issues related to the statusbar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants