Search in workspace improvements #6798
Conversation
svenefftinge
force-pushed
the
se/search-improvements
branch
from
c8c084c to
899f1c9
Compare
svenefftinge
force-pushed
the
se/search-improvements
branch
from
899f1c9 to
5179060
Compare
svenefftinge
requested review from
vince-fugnitto,
elaihau,
akosyakov and
AlexTugarev
|
As far as I can tell from the code, search results should be collapsed if
SIW seems not work this way with this change.
|
| } | ||
|
|
||
| return a.length - b.length; | ||
| return 0; |
There was a problem hiding this comment.
why do the "line" and "character" not matter any more?
There was a problem hiding this comment.
Because a result contains all matches of a file
packages/search-in-workspace/src/node/ripgrep-search-in-workspace-server.ts
Show resolved
Hide resolved
akosyakov
added
performance
svenefftinge
force-pushed
the
se/search-improvements
branch
from
5179060 to
9ee0c1f
Compare
|
Thanks for the feedback. I have fixed the auto collapse. |
There was a problem hiding this comment.
I believe the Cancel Search toolbar item should only be visible if there is an ongoing search (with a search term present) similarly to VS Code. At the moment, the following is displayed:
Also, I believe the PR closes the following issue: #6461
- one message per file with multiple matches - long lines are not send entirely to clients - new option for max file size (defaults to 20M) Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
force-pushed
the
se/search-improvements
branch
from
9ee0c1f to
6111061
Compare
|
Good catch! I could only reproduce by first entering a search and then deleting it. I've fixed that. |
|
@vince-fugnitto @elaihau please give your approve if you are fine with changes. Right now browser UI is hanging very often it would be good to have it in. |
There was a problem hiding this comment.
It works great for me 👍
I noticed that:
- the overall performance is much better and is less likely to go offline
- my previous issue has been resolved (visibility of the
cancelthe toolbar item) - having the
canceltoolbar item and command allows users to successfully terminate long searches - the search respects the preference
collapseResultsandlineNumbers
What it does
Improves search in workspace performance by sending less messages and avoid sending long lines entirely.
How to test
Search for something including ignored files.
Review checklist
Reminder for reviewers