Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show text document view column #6824

Merged

Conversation

godlin-gh
Copy link
Contributor

What it does

fix #6800 #6801

How to test

  1. clone my test plugin into plugins dir and build plugin
mkdir plugins
cd plugins
git clone https://github.com/godlin-gh/vscode-document-api-test.git
cd vscode-document-api-test
yarn
yarn compile
  1. add this to launch.json
    {
      "name": "Launch VS Code ShowDocument API Test",
      "type": "node",
      "request": "launch",
      "args": [
        "${workspaceFolder}/examples/browser/src-gen/backend/main.js",
        "${workspaceFolder}/plugins/vscode-document-api-test/testWorkspace",
        "--port",
        "3030",
        "--hostname",
        "0.0.0.0",
        "--extensionTestsPath=${workspaceFolder}/plugins/vscode-document-api-test/out/test/suite/index",
        "--hosted-plugin-inspect=9339"
      ],
      "env": {
        "THEIA_DEFAULT_PLUGINS": "local-dir:${workspaceFolder}/plugins",
        "THEIA_WEBVIEW_EXTERNAL_ENDPOINT": "${env:THEIA_WEBVIEW_EXTERNAL_ENDPOINT}"
      },
      "stopOnEntry": false,
      "sourceMaps": true,
      "outFiles": [
        "${workspaceFolder}/../.js"
      ]
    }
  1. debug or run
    image
  2. open http://localhost:3030
    image

There should be four editors divided into two groups

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look for the moment at the PR and I believe the commit 79da67b should be squashed since it is simply fixing an issue from a previous commit of the same pull request.


I tried and it looks like it works correctly, here are my results when running on master:

Screen Shot 2020-01-05 at 6 49 27 PM

and using your pull request:

Screen Shot 2020-01-05 at 6 53 48 PM

@vince-fugnitto vince-fugnitto added bug bugs found in the application plug-in system issues related to the plug-in system labels Jan 5, 2020
…ions type

Signed-off-by: Gan Lin <ganlinbupt@163.com>
@godlin-gh godlin-gh force-pushed the fix-show-text-document-view-column branch from 79da67b to 31682f2 Compare January 6, 2020 03:20
@godlin-gh
Copy link
Contributor Author

I took a quick look for the moment at the PR and I believe the commit 79da67b should be squashed since it is simply fixing an issue from a previous commit of the same pull request.

I tried and it looks like it works correctly, here are my results when running on master:

Screen Shot 2020-01-05 at 6 49 27 PM

and using your pull request:

Screen Shot 2020-01-05 at 6 53 48 PM

I've squashed that two commits now.

… toEditorOpenerOptions() method

Signed-off-by: Gan Lin <ganlinbupt@163.com>
@godlin-gh godlin-gh force-pushed the fix-show-text-document-view-column branch from 31682f2 to 9e560df Compare January 6, 2020 03:29
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@godlin-gh very good job! code changes look good, thanks @vince-fugnitto for testing!

@akosyakov akosyakov merged commit 9404b2e into eclipse-theia:master Jan 6, 2020
@godlin-gh godlin-gh deleted the fix-show-text-document-view-column branch January 6, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin api window.showTextDocument was't implemented correctly
3 participants