[markers] add problem decorator fontData #6863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
approved these changes
Jan 23, 2020
@marechal-p
Open the 
|
|
@lmcbout would you like to try the pull-request? |
lmcbout
approved these changes
Mar 12, 2020
|
anything else has to be done before merging? |
@akosyakov no there shouldn’t be anything else, I was hoping for others to give a review as well but if we are happy with the changes I will merge :) |
|
I'll merge the pull-request tomorrow morning if there are no objections. |
- added `fontData` to the problem decorators in the explorer which decorates the node with a foreground color with the highest marker severity. - added a new method `getPriority()` which takes as argument a marker diagnostic and returns it's priority which is used when decorating. Markers with a higher severity have a higher priority. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/problem-decorator
branch
from
e56b38c to
7e178ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com
What it does
fontDatato the problem decorators in the explorer which decorates the node with a foreground color with the highest marker severity.getPriority()which takes as argument a marker diagnostic and returns it's priority which is used when decorating. Markers with a higher severity have a higher priority.How to test
Review checklist
Reminder for reviewers