-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude all numpad keys from keyboard mapping #6881
Conversation
@spoenemann build is failing
Not sure who can test it. @eclipse-theia/ecd-theia-committers ? |
@westbury Would you have a few minutes to give this a spin? |
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I cannot reproduce the problem without the fix. I have tried both the parent commit (f11045a) and also from our Electron IDE. I always see numbers for the number keys along the top row above the letters, and either numbers or page up/down etc on the numeric pad (as appropriate for num-lock on/off). I did have to connect an external keyboard to my Windows 10 laptop to get the numeric pad.
Perhaps it depends on the particular keyboard layouts? I had three already installed. If you let me know the layouts I will try with those.
I had difficulties reproducing the problem, too (see arduino/arduino-pro-ide#129). For me it helped to switch between different layouts using the task bar selector, or to remove and add again the additional layouts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I can now reproduce reliably by switch away from US layout and switching back. With the fix I cannot reproduce the problem at all. So I am convinced as can be that this PR fixes the problem.
What it does
Fixes #6872.
How to test
3
and9
.3
and9
should be written into the editor.Review checklist
Reminder for reviewers