Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] don't let disabled bindings shadow enabled ones #7022

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Jan 30, 2020

bindings contributed from VS Code extensions do currently always shadow
bindings default bindings, no matter they are enabled or not.

What it does

This change checks whether a binding is enabled before including it in any shadowing logic.

How to test

Change the binding of a (usually inactive) keybinding to Alt+Enter. (or install the python vscode extension)
No open text editor search, search something in an editor and press
Alt+Enter.

It should mark all findings setting multiple cursors.

Review checklist

Reminder for reviewers

@kittaakos
Copy link
Contributor

I have tried it with the VS Code Python extension, extracted it and copied to the plugins folder. I can see the extension has started:

...
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /Users/akos.kitta/git/theia/plugins/ms-python.python
root INFO Resolved "ms-python.python" to a VS Code extension "python@2020.1.58038" with engines: { vscode: '^1.38.0' }
...
root INFO Deploying backend plugin "python@2020.1.58038" from "/Users/akos.kitta/git/theia/plugins/ms-python.python/extension/out/client/extension"
...
root INFO [0e244ea0-37a0-4f8d-ae97-ebc69c53a7be][ms-python.python]: Loaded contributions.
...
root INFO [0e244ea0-37a0-4f8d-ae97-ebc69c53a7be][ms-python.python]: Started plugin.
....

but I cannot set the cursor on the search matches in editor (Cmd+F > search > Alt+Enter).

bindings contributed from VS Code extensions do currently always shadow
bindings default bindings, no matter they are enabled or not.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@svenefftinge
Copy link
Contributor Author

@kittaakos sorry, I forgot to push part of my change. The PR is now updated and I have verified it once more.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it again, and it works now. 👍 Thank you for the fix!

screencast 2020-01-30 20-06-50

@svenefftinge svenefftinge merged commit 83101c3 into master Jan 30, 2020
@svenefftinge svenefftinge deleted the se/kb_shadowing branch January 30, 2020 19:30
@akosyakov akosyakov added keybindings issues related to keybindings vscode issues related to VSCode compatibility labels Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants