Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree text highlighting #7025

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Fix tree text highlighting #7025

merged 1 commit into from
Jan 31, 2020

Conversation

justin8502
Copy link
Contributor

Issue: #6919

What it does

  • Matches color of highlighted text when filtering within the explorer window & file dialog.

How to test

  • Filter by typing within the explorer window. To check File Dialog, select File -> Open Workspace, then attempt to type within the file viewer.

Review checklist

Reminder for reviewers

- Changed tree.css file to override default mark color (black) with
foreground color (--theia-list-inactiveSelectionForeground).

Signed-off-by: Justin Ang <justinang13@gmail.com>
@akosyakov akosyakov added the tree issues related to the tree (ex: tree widget) label Jan 31, 2020
@akosyakov
Copy link
Member

Please pay attention to different trees in different themes during the review, not only to the navigator in the default theme.

@akosyakov akosyakov added the theming issues related to theming label Jan 31, 2020
@akosyakov
Copy link
Member

@jbicker does not seem to be a committer on github anymore for this repo, although he is on the eclipse page, cc @marcdumais-work @eclipsewebmaster

wanted to assign him as a reviewer

@kittaakos
Copy link
Contributor

Nice, @JustinAng1 👍

Dark Theme:

VS Code:
Screen Shot 2020-01-31 at 09 44 56

Theia
Screen Shot 2020-01-31 at 09 44 09

Theia (File Dialog):
Screen Shot 2020-01-31 at 09 39 42


Light Theme:

VS Code:
Screen Shot 2020-01-31 at 09 47 58

Theia:
Screen Shot 2020-01-31 at 09 47 49

not only to the navigator

It seems, only the navigator supports the search.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great. Thank you, @JustinAng1 👍

@kittaakos kittaakos merged commit 4f6ff90 into eclipse-theia:master Jan 31, 2020
@marcdumais-work
Copy link
Contributor

@jbicker does not seem to be a committer on github anymore for this repo, although he is on the eclipse page, cc @marcdumais-work @eclipsewebmaster

wanted to assign him as a reviewer

Confirmed - I do not see Jan in the members of eclipse-theia org. @jbicker there has been this type of issue with a few committers already. In at least one case the root cause was with the Eclipse Foundation sync script that keeps the org membership in-sync with current committers. It might also be that the invite email was lost. e.g. in your spam folder.

The simplest is for you to open a bugzilla about the issue. Start here and chose GitHub as component. Please keep us updated with the progress.

@marcdumais-work
Copy link
Contributor

@jbicker does not seem to be a committer on github anymore for this repo, although he is on the eclipse page, cc @marcdumais-work @eclipsewebmaster

wanted to assign him as a reviewer

FYI, Similar was just reported for a Red Hat committer:
https://github.com/orgs/eclipse-theia/teams/ecd-theia-committers/discussions/2

@jbicker
Copy link
Contributor

jbicker commented Jan 31, 2020

Hi,
@marcdumais-work: thank you for the help. I wasn't able to open the link to the discussion but I've already send a mail to @eclipsewebmaster anyways. It turned out that I had to add my GitHub ID to my Eclipse Account. So, I hope to get a new invitation from the eclipse sync tool to join the theia world again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theming issues related to theming tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants