Amending without previous commit fails #7032 #7033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
vince-fugnitto
added
git
vince-fugnitto
approved these changes
Jan 31, 2020
lmcbout
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Tested on Chrome and Ubuntu 16.04
Works fine as well for me
Thanks @JonasHelming
westbury
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonas Helming jhelming@eclipsesource.com
What it does
Check on amend, whether there is a previous commit in the repo and shows an error to the user if not
How to test
Init a new repo, try to amend a change
Review checklist
Reminder for reviewers