Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-ext: lookup plugins in user home dir #7086

Closed
wants to merge 1 commit into from

Conversation

paul-marechal
Copy link
Member

@paul-marechal paul-marechal commented Feb 5, 2020

Signed-off-by: Paul Maréchal paul.marechal@ericsson.com

What it does

Allow configuring plugin locations via backend configuration, and look into the user home by default.

How to test

  • After running yarn, move/rename the plugins directory.
  • Start the browser application, no plugin should be found.
  • Go to examples/browser/src-gen/main.js and edit:
BackendApplicationConfigProvider.set({
    plugins: ['local-dir:../../<renamed-plugin-folder>']
});
  • Start the browser application, plugins should be found.
  • Move the plugin folder to:
    • Windows: C:\Users\<username>\AppData\Roaming\.theia\extensions
    • Linux: /home/<username>/.theia/extensions
  • Start the browser application, plugins should be found.
  • Repeat the steps for the electron application.

Review checklist

Reminder for reviewers

@paul-marechal
Copy link
Member Author

paul-marechal commented Feb 5, 2020

Or is it better to have applications/clients do these extra lookups by themselves?

@vince-fugnitto vince-fugnitto added the plug-in system issues related to the plug-in system label Feb 5, 2020
Allow configuring plugin locations via backend configuration, and look
into the user home by default.

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@benoitf
Copy link
Contributor

benoitf commented Feb 5, 2020

Hello,
I think it may be confusing if plug-ins are looked into something called extensions ?

besides the name I would say that it's up to the Application to setup this (they can also just define THEIA_PLUGINS env var in their startup to any location) like local-dir://${HOME}/.theia/plugins or whatever

@akosyakov
Copy link
Member

I don't understand what it tries to solve and why we need yet another way to specify plugin dir. What we need for browser/electron that extensions are preserved on theia restart, for it indeed extension should be loaded from theia dir always, but also stored there on installation. In order to work on it first #6650 should be landed.

@paul-marechal
Copy link
Member Author

Makes sense, thanks.

@marcdumais-work marcdumais-work deleted the mp/plugin-list branch February 21, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants