[#6891] Add support for setting the icon of a submenu #7091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Feb 6, 2020
akosyakov
reviewed
Feb 6, 2020
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
akosyakov
approved these changes
Feb 7, 2020
|
@eclipse-theia/ecd-theia-committers maybe someone have an idea why linux build is failing, something with ubuntu |
Looks like an internal Travis issue, happening while setting-up the executor. I'll restart it and hopefully this glitch is gone. |
|
I tried to build these changes locally on |
It passed now: https://travis-ci.com/eclipse-theia/theia/jobs/284684985 |
|
@marcdumais-work @RomanNikitenko thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR adds support for setting the icon class of a submenu when registering it via
MenuModelRegistry.How to test
Examples:
registry.registerSubmenu(CommonMenus.FILE_SETTINGS_SUBMENU, 'Settings', { iconClass: "theia-collapse-all-icon" });registry.registerSubmenu(NavigatorContextMenu.OPEN_WITH, 'Open With', { iconClass: "theia-collapse-all-icon" });Signed-off-by: Vivien Jovet vivien.jovet@gmail.com