markers: improve 'description'

[vince-fugnitto]

What it does

The following pull-request improves the description for the MarkerInfoNodes:

marker-tree-label-provider.ts:

The marker-tree-label-provider.ts has been updated to handle
extra cases where we want custom behavior when displaying the description.
These cases include omitting the description for when a file resource
located at the workspace root is opened with markers in both single
and multiple root workspaces. This behavior aligns the problems-view
further with what VS Code provides.

marker-tree-label-provider.spec.ts:

The marker-tree-label-provider.spec.ts has been updated to include a new
label contribution provider (WorkspaceUriLabelProviderContribution), in
order to get a better label representation of a real-world application. The test
cases have also been updated and split into a more readable and verbose format.
The test cases for getLongName() have been updated to include both single and
multiple root test cases.

How to test

1. start the application using both a single and multiple root workspace
2. in general, the following should hold true:

Root	Test Case	Result (description)
single	open a file not at the workspace root	the parent directory should be displayed
single	open a file at the workspace root	no description should be displayed
single	open a file outside of the workspace	the full path should be displayed
multi	open a file at not at one of the workspace roots	the root name and parent folder should be displayed
multi	open a file at one of the workspace roots	only the root name should be displayed
multi	open a file outside of any workspace root	only the full path of the resource should be displayed

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

[vince-fugnitto]

@lmcbout the pull-request has been rebased to include #7207 and new handling (with corresponding tests) has been added to handle resources outside of the current workspace root(s).

[lmcbout]

Tested on Ubuntu 18.08, Chrome and Electron.
Works fine as expected and tests are also running fine.

[elaihau]

Worked really well.

I tested on gitpod. The following edge cases worked:

1. Opens one folder as a workspace, and one ts file outside the workspace.
2. Opens one folder, and its parent folder as the second root, to make a multi root workspace.

Thank you for the change !

[vince-fugnitto]

Thank you for the review @lmcbout @Anasshahidd21 @elaihau !