fix presentation.reveal & focus for detected tasks

[elaihau]

• default values of the taskConfig.presentation object are not taken
  into consideration when detected tasks are started. This pull request
  fixes the bug.
• fixes task.presentation does not work properly for detected tasks #7547

Signed-off-by: Liang Huang lhuang4@ualberta.ca

How to test

1. define a detected task, e.g., npm run list

"scripts": {
  "list": "sleep 1 && ls"
}

2. make sure npm run list is not customized in tasks.json
3. run npm run list as a detected task. Check if the terminal widget is revealed
4. customize the npm run list in tasks.json by adding the presentation object.
5. Re-run the customized task, and see if the presentation works as expected.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

[vince-fugnitto]

I verified the changes using the provided test case and it worked correctly for me! 👍

[RomanNikitenko]

Tested for tsc:watch detected and configured tasks
It works as expected for me!

[RomanNikitenko]

Looks like it's working well without these changes for configured/customized configurations, because a configuration from tasks.json file comes with default values for presentation.

I guess a configuration for a detected task comes without default value for presentation field.

[elaihau]

I guess a configuration for a detected task comes without default value for presentation field.

yes that's the root cause of this bug.

I will take a look if I can fix it from another angle - maybe the default values should be assigned when the tasks are retrieved from the providers.

Thank you Roman !