Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented more vscode.executeXXX commands #7563

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

JPinkney
Copy link
Contributor

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

What it does

This PR implements a few more vscode.executeXXX commands:

  • vscode.executeDefinitionProvider
  • vscode.executeDeclarationProvider
  • vscode.executeTypeDefinitionProvider
  • vscode.executeHoverProvider
  • vscode.executeDocumentHighlights
  • vscode.executeFormatDocumentProvider
  • vscode.executeFormatRangeProvider
  • vscode.executeFormatOnTypeProvider

It also reorganizes the current commands so that they are in-line with the built-in commands documentation from VSCode

How to test

You can test this PR by first adding vscode java into your plugins.

Then clone https://github.com/JPinkney/executeXXXCommands into the theia plugins folder and from theia/examples/browser run yarn run start ../../plugins/test/testWorkspace/ so that theia correctly starts with the test workspace. Then open MySample.java.

The plugin registers vscode commands that call the new vscode.executeXXX apis. Open the command palette and then type execute and you should see a commands such as executeHoverProvider if you press on one of these commands it will log the output to the terminal where you started theia.

Review checklist

Reminder for reviewers

@JPinkney JPinkney force-pushed the vscode.executeXXX branch from e730c28 to bc2863b Compare April 13, 2020 21:50
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@JPinkney JPinkney self-assigned this Apr 14, 2020
@JPinkney JPinkney added the vscode issues related to VSCode compatibility label Apr 14, 2020
@akosyakov
Copy link
Member

@JPinkney could you check commands here: #4050

Also It will be good to update the issue with commands which are registered in https://github.com/microsoft/vscode/blob/master/src/vs/workbench/api/common/extHostApiCommands.ts but missing in docs

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed your instructions however can only see 7 commands (not all 8). am i misunderstanding something?
Peek 2020-04-14 21-54

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also could not find a command for last provider, but code looks good and other providers work. Thank you!

@akosyakov
Copy link
Member

@JPinkney merging?

@JPinkney JPinkney merged commit f691918 into eclipse-theia:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants