Implemented more vscode.executeXXX commands #7563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What it does
This PR implements a few more vscode.executeXXX commands:
It also reorganizes the current commands so that they are in-line with the built-in commands documentation from VSCode
How to test
You can test this PR by first adding vscode java into your plugins.
Then clone https://github.com/JPinkney/executeXXXCommands into the theia plugins folder and from
theia/examples/browser
runyarn run start ../../plugins/test/testWorkspace/
so that theia correctly starts with the test workspace. Then open MySample.java.The plugin registers vscode commands that call the new vscode.executeXXX apis. Open the command palette and then type
execute
and you should see a commands such asexecuteHoverProvider
if you press on one of these commands it will log the output to the terminal where you started theia.Review checklist
Reminder for reviewers