Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump VS Code API version to 1.44.0 #7564

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Apr 14, 2020

What it does

Fixes #7243

How to test

I tested this using Vetur extension. With Theia at master it warns that Vue Language Server cannot be used, after bump it works the same as it does in VS Code.

Review checklist

Reminder for reviewers

Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Apr 14, 2020
@akosyakov
Copy link
Member

@benoitf please merge

@benoitf benoitf merged commit c3d6b9f into eclipse-theia:master Apr 14, 2020
@dsseng dsseng deleted the bump-vscode-api branch April 14, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elm Extension won't start because it requires VSCode 1.42
3 participants