Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage cache lifetime explicitly #7633

Conversation

tsmaeder
Copy link
Contributor

Signed-off-by: Thomas Mäder tmader@redhat.com

What it does

How to test

Review checklist

Reminder for reviewers

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@akosyakov
Copy link
Member

@tsmaeder no need to look yet correct? If not please elaborate a bit in What it does section please 🙏

@tsmaeder
Copy link
Contributor Author

It's a "counterproposal" to #7536. I did it in 2 hours and can't guarantee I caught all the cases. Still would be interested in hearing your opinion on the approach. If you had a look at provided-tasks-configurations.ts, that would be useful.

@tsmaeder
Copy link
Contributor Author

Looks like I inherited the job ;-) @akosyakov I'll get back to this within the next 2-3 weeks.

@akosyakov
Copy link
Member

@tsmaeder ok, then I will look next week

@akosyakov
Copy link
Member

akosyakov commented Apr 30, 2020

I think it is somehow related to #7670 (comment)

We should rather remove caches and compute task map to resolve whenever a user wants to run or a VS Code extension wants to fetch tasks. I think that's actually an effect of this PR it clean caches each such time, but then what is the point of a cache.

cc @RomanNikitenko @elaihau

@akosyakov akosyakov added tasks issues related to the task system vscode issues related to VSCode compatibility labels Apr 30, 2020
@elaihau
Copy link
Contributor

elaihau commented Apr 30, 2020

I think it is somehow related to #7670 (comment)

We should rather remove caches and compute task map to resolve whenever a user wants to run or a VS Code extension wants to fetch tasks. I think that's actually an effect of this PR it clean caches each such time, but then what is the point of a cache.

Yes I will put my work on hold until your recent changes and this PR get merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants