feat(branding): Change default name to 'Eclipse Theia' instead of 'Theia'

[benoitf]

What it does

Change default name from Theia to Eclipse Theia
following comment #7642 (comment)

How to test

remove theia element of examples/browser/package.json

"theia": {
    "frontend": {
      "config": {
        "applicationName": "Theia Browser Example",
        "preferences": {
          "files.enableTrash": false
        }
      }
    }
  },

Use Help/About menu

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Change-Id: I3cb908805fd9050404d2b433e5cbd2dcfd433e70
Signed-off-by: Florent Benoit fbenoit@redhat.com

[vince-fugnitto]

The changes look good to me, I'd like to have the opinion of @marcdumais-work however but I don't see any reason to object to modifying the default prop to indicate Eclipse Theia vs Theia.

[benoitf]

@marcdumais-work ?

[marcdumais-work]

@marcdumais-work ?

Correct, thanks @benoitf . But I own the other account as well, so no biggie :)

[benoitf]

it was just to ping you :-)

[marcdumais-work]

LGTM!